Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type hints for python 3.8 compatibility #118

Merged
merged 4 commits into from
Jan 12, 2024
Merged

fix type hints for python 3.8 compatibility #118

merged 4 commits into from
Jan 12, 2024

Conversation

nim65s
Copy link
Collaborator

@nim65s nim65s commented Jan 12, 2024

This is super hard to do, and will be super easy to undo via pyupgrade/ruff, so let's keep it.

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (5a07e70) 21.13% compared to head (dddd0a9) 21.15%.

Files Patch % Lines
happypose/toolbox/datasets/web_scene_dataset.py 0.00% 5 Missing ⚠️
...ose_estimators/megapose/training/train_megapose.py 0.00% 4 Missing ⚠️
happypose/toolbox/datasets/datasets_cfg.py 0.00% 3 Missing ⚠️
happypose/toolbox/visualization/bokeh_plotter.py 0.00% 3 Missing ⚠️
...ose/cosypose/scripts/run_full_cosypose_eval_new.py 0.00% 2 Missing ⚠️
...imators/megapose/scripts/run_full_megapose_eval.py 0.00% 2 Missing ⚠️
...s/megapose/scripts/run_inference_on_datasettemp.py 0.00% 2 Missing ⚠️
...ators/megapose/scripts/run_inference_on_example.py 0.00% 2 Missing ⚠️
.../scripts/run_inference_on_example_newdetections.py 0.00% 2 Missing ⚠️
happypose/toolbox/datasets/gso_dataset.py 0.00% 2 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #118      +/-   ##
==========================================
+ Coverage   21.13%   21.15%   +0.02%     
==========================================
  Files         216      216              
  Lines       18045    18054       +9     
==========================================
+ Hits         3813     3819       +6     
- Misses      14232    14235       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nim65s nim65s merged commit f5f1faf into dev Jan 12, 2024
15 checks passed
@nim65s nim65s deleted the py38 branch January 12, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nim65s @MedericFourmy